[webkit-reviews] review requested: [Bug 39140] Add support for 4 and 8 hexit CSS hexcolor values : [Attachment 56127] Patch with tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 17:47:23 PDT 2010


Tab Atkins <tabatkins at google.com> has asked  for review:
Bug 39140: Add support for 4 and 8 hexit CSS hexcolor values
https://bugs.webkit.org/show_bug.cgi?id=39140

Attachment 56127: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=56127&action=review

------- Additional Comments from Tab Atkins <tabatkins at google.com>
@Micheal: Ah, now I feel silly.  I have no idea why I went with serial ifs over
a switch.  Hopefully I got the webkit style with regards to switch indentation.


@Darin: I'm running some tests right now to see if there is any significant
usage of 4 or 8 hexit colors on the web.  Hopefully I'll see some results over
the weekend.


More information about the webkit-reviews mailing list