[webkit-reviews] review canceled: [Bug 39140] Add support for 4 and 8 hexit CSS hexcolor values : [Attachment 56120] Patch with tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 17:16:19 PDT 2010


Tab Atkins <tabatkins at google.com> has canceled Tab Atkins
<tabatkins at google.com>'s request for review:
Bug 39140: Add support for 4 and 8 hexit CSS hexcolor values
https://bugs.webkit.org/show_bug.cgi?id=39140

Attachment 56120: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=56120&action=review

------- Additional Comments from Tab Atkins <tabatkins at google.com>
Fixed final tab issues, and made a manual check through the patch for further
tabs.

I think the issues with my expected output file are due to me working on a
windows machine but working through cygwin.  The file, as it exists, appears to
be what's required for tests to pass on my machine.  I can renormalize the
linebreaks to unix-style if necessary, though.


More information about the webkit-reviews mailing list