[webkit-reviews] review denied: [Bug 39131] Move text encoding detection logic from FileReader to a generic location : [Attachment 56101] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 16:49:05 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 39131: Move text encoding detection logic from FileReader to a generic
location
https://bugs.webkit.org/show_bug.cgi?id=39131

Attachment 56101: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=56101&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Encoding sniffing is definitely not something the TextEncoding class should
responsible for. And I think that we already have all the code for this - can't
you just feed the data to TextResourceDecoder as text/plain?


More information about the webkit-reviews mailing list