[webkit-reviews] review denied: [Bug 39135] Rename GenericWorkerTask.h to GenericTask.h and move it to dom directory : [Attachment 56108] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 14:49:42 PDT 2010


David Levin <levin at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 39135: Rename GenericWorkerTask.h to GenericTask.h and move it to dom
directory
https://bugs.webkit.org/show_bug.cgi?id=39135

Attachment 56108: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=56108&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It looks good to me except for the fact that
WebCore/WebCore.xcodeproj/project.pbxproj isn't fixed up completely. For
example, the files haven't been moved to the correct new directory.

I think I know how to fix this by hand (look for "children =" in that file),
but in general this points out to me that the pbxproj file is tricky to edit by
hand. I'd suggest that it would be better to open this file in xcode and delete
the file and re-add it (if possible).


More information about the webkit-reviews mailing list