[webkit-reviews] review granted: [Bug 37945] CMake buildsystem : [Attachment 56111] CMake build system, with EFL port dependent files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 14 14:45:58 PDT 2010
Adam Treat <treat at kde.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 37945: CMake buildsystem
https://bugs.webkit.org/show_bug.cgi?id=37945
Attachment 56111: CMake build system, with EFL port dependent files
https://bugs.webkit.org/attachment.cgi?id=56111&action=review
------- Additional Comments from Adam Treat <treat at kde.org>
Overall, I like this version much much better and think it is a good first step
for a cmake buildsystem that can grow to include more ports. My other big
style nitpick is the choice of UPPERCASE vs lowercase, but I'm not willing to
r- on this account alone as lots of cmake buildsystems have this.
More information about the webkit-reviews
mailing list