[webkit-reviews] review granted: [Bug 24906] 0x5C of EUC-JP is not Yen Sign but U+005C : [Attachment 55964] Patch v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 24906: 0x5C of EUC-JP is not Yen Sign but U+005C
https://bugs.webkit.org/show_bug.cgi?id=24906

Attachment 55964: Patch v2
https://bugs.webkit.org/attachment.cgi?id=55964&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    // FIXME: We don't need transcoding when the document explicitly
+    // specifies a font which doesn't change backslashes into yen signs.

This does seem like something that could cause trouble indeed.

+FontTranscoder& fontTranscoder()
+{
+    static FontTranscoder* transcoder = new FontTranscoder;
+    return *transcoder;
+}

This should use DEFINE_STATIC_LOCAL. I'm not really sure why we're still doing
this, but that's what we are doing.

r=me. You may want to give Darin and Dan some time to comment, if they want to.