[webkit-reviews] review granted: [Bug 39008] REGRESSION (r58950): Webkit crashes on clicking back button when in hotmail : [Attachment 56083] proposed fix

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 39008: REGRESSION (r58950): Webkit crashes on clicking back button when in
hotmail
https://bugs.webkit.org/show_bug.cgi?id=39008

Attachment 56083: proposed fix
https://bugs.webkit.org/attachment.cgi?id=56083&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>

> @@ -1978,12 +1955,19 @@ void Document::write(const SegmentedStri
>      if (!m_tokenizer)
>	   open(ownerDocument);
>  
> -    {
> -	   ASSERT(m_tokenizer);
> -	   SynchronousHTMLTokenizerGuard tokenizerGuard(m_tokenizer.get());
> -	   m_tokenizer->write(text, false);
> +    ASSERT(m_tokenizer);
> +    bool wasForcedSynchronous = false;
> +    HTMLTokenizer* tokenizer = m_tokenizer->asHTMLTokenizer();
> +    if (tokenizer) {
> +	   wasForcedSynchronous = tokenizer->forceSynchronous();
> +	   tokenizer->setForceSynchronous(true);
>      }
>  
> +    m_tokenizer->write(text, false);
> +
> +    if (m_tokenizer && tokenizer && m_tokenizer->asHTMLTokenizer() ==
tokenizer)
> +	   tokenizer->setForceSynchronous(wasForcedSynchronous);
> +

Couldn't this last if block also include "!wasForcedSynchronous" as a
condition, and it would always tokenizer->setForceSynchronous(false)?

r+ with that consideration.