[webkit-reviews] review requested: [Bug 39008] REGRESSION (r58950): Webkit crashes on clicking back button when in hotmail : [Attachment 56083] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 14 10:13:41 PDT 2010
Alexey Proskuryakov <ap at webkit.org> has asked for review:
Bug 39008: REGRESSION (r58950): Webkit crashes on clicking back button when in
hotmail
https://bugs.webkit.org/show_bug.cgi?id=39008
Attachment 56083: proposed fix
https://bugs.webkit.org/attachment.cgi?id=56083&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I removed the helper class, because:
1) I didn't like its name.
2) In a tricky place like this, it's probably best to be explicit about which
tokenizer is being accessed.
Technically, it would be just as easy to have the checks in helper class by
making it hold a Document pointer.
More information about the webkit-reviews
mailing list