[webkit-reviews] review granted: [Bug 39087] Show a console message when X-Frame-Options blocks a load : [Attachment 56057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 09:23:54 PDT 2010


Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39087: Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087

Attachment 56057: Patch
https://bugs.webkit.org/attachment.cgi?id=56057&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       DEFINE_STATIC_LOCAL(String, consoleMessage, ("Refused to display
document because display forbidden by X-Frame-Options.\n"));

Is it good for console messages passed to addMessage to have a trailing
newline. That doesn't seem right to me.

The grammar here seems slightly strained. Does the word "display" need to be
repeated twice?


More information about the webkit-reviews mailing list