[webkit-reviews] review granted: [Bug 19946] Possible misalignment in RenderArena when compiled for debug : [Attachment 56070] Add alignment based on AllocAlignmentInteger for Arenas.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 09:02:35 PDT 2010


Darin Adler <darin at apple.com> has granted David Tapuska <dtapuska at rim.com>'s
request for review:
Bug 19946: Possible misalignment in RenderArena when compiled for debug
https://bugs.webkit.org/show_bug.cgi?id=19946

Attachment 56070: Add alignment based on AllocAlignmentInteger for Arenas.
https://bugs.webkit.org/attachment.cgi?id=56070&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#include <wtf/FastMalloc.h>
> +#include <wtf/Platform.h>

Since FastMalloc.h already includes Platform.h, there is no need to include
Platform.h here.

> +#ifdef WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER
> +#define ARENA_ALIGN_MASK (sizeof(WTF::AllocAlignmentInteger) - 1)
> +#else
>  #define ARENA_ALIGN_MASK 3
> +#endif

I think it would be good eventually to get rid of
WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER and always do this. A FIXME mentioning
that would be a plus.

r=me


More information about the webkit-reviews mailing list