[webkit-reviews] review requested: [Bug 36463] Spatial Navigation: make it work with focusable elements in overflow content : [Attachment 56073] patch v4 - patch ready for review

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 36463: Spatial Navigation: make it work with focusable elements in overflow
content
https://bugs.webkit.org/show_bug.cgi?id=36463

Attachment 56073: patch v4 - patch ready for review
https://bugs.webkit.org/attachment.cgi?id=56073&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch addresses the problem that current Spatial Navigation does not properly
traverse scrollable contents, including scrollable div's. For that, a new class
member called scrollableEnclosingBox was introduced to FocusCandidate class to
keep the track of current scrollable box Node wrapping a FocusCandidate. The
common case is obviously that there is no scrollable container wrapping it.
    
To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal
algorithm routine  (FocusController::findNextFocusableInDirection) was changed
as follows: At the time it encounters a scrollable Node (read for now a
scrollable div), each focusable node that is inner of it keeps track of the
scrollable node. By the time a sibling of the scrollable Node in case is
encountered, there is not need to track this reference any more, and the
traverse continues ...
    
updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.