[webkit-reviews] review denied: [Bug 33725] .selectorText and .cssText on CSSRule don't escape '.' and ':' : [Attachment 56045] Fix for Bug 33725 - .selectorText and .cssText on CSSRule don't escape '.' and ':'

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 33725: .selectorText and .cssText on CSSRule don't escape '.' and ':'
https://bugs.webkit.org/show_bug.cgi?id=33725

Attachment 56045: Fix for Bug 33725 - .selectorText and .cssText on CSSRule
don't escape '.' and ':'
https://bugs.webkit.org/attachment.cgi?id=56045&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is only scratching the surface of the characters that might need quoting.
All other non-identifier characters need to be escaped too. This needs logic
something like what we have in the quoteCSSString function in CSSParser.cpp. I
think I'd call it escapeCSSIdentifierIfNeeded and put it in CSSParser.cpp
alongside quoteCSSString and quoteCSSStringIfNeeded.