[webkit-reviews] review requested: [Bug 39108] WebKit build failure on Linux for Qt4.5 : [Attachment 56051] patch that fixes the build failure for Qt4.5 on Linux
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 13 20:39:10 PDT 2010
Charles Wei <charles.wei at torchmobile.com.cn> has asked for review:
Bug 39108: WebKit build failure on Linux for Qt4.5
https://bugs.webkit.org/show_bug.cgi?id=39108
Attachment 56051: patch that fixes the build failure for Qt4.5 on Linux
https://bugs.webkit.org/attachment.cgi?id=56051&action=review
------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
fixes the build failure of WebKit for Qt 4.5 on Linux.
1. Remove the un-used include file <QScopedPointer> in
WebKit/qt/WebCoreSupport/QtPlatformPlugin.cpp, which is a QT4.6 specific
class. If this class is later used , please include it back, and make it
Qt4.6 specific.
2. make QGraphicsWebViewPrivate::syncLayers() in
WebKit/qt/WebCoreSupport/WebKit/qt/WebCoreSupport/QtPlatformPlugin.cpp always
available, but the implementation empty when not USE ACCELERATED_COMPOSITING,
as indicated in the header file .
More information about the webkit-reviews
mailing list