[webkit-reviews] review granted: [Bug 38992] REGRESSION: Crash by pasting to a textarea with white-space:nowrap : [Attachment 55952] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 38992: REGRESSION: Crash by pasting to a textarea with white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=38992

Attachment 55952: Patch
https://bugs.webkit.org/attachment.cgi?id=55952&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Not new to this patch: It's very strange that this code specifically
special-cases <div> elements. There's nothing unqiue about a <div> elements, is
there? Can't a <p> elements perform almost the identical function?

The check that an element has a grandparent seems to be a roundabout way to
define a "root node" that depends on the one hand on the fact that we use
document fragments with single nodes in them and on the other hand on the fact
that a document has an HTML element in it. I'd think that in the case of a
document we'd not want to add a sibling to a body node either, so I think the
parent->parent check is not ideal.

But r=me on this change for now, since it does some good and no harm.

I'd like further thought and testing, though, since this seems a little loose.