[webkit-reviews] review denied: [Bug 24943] Command-B and Command-I do not generate keydown events in contentEditable regions. : [Attachment 50765] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 24943: Command-B and Command-I do not generate keydown events in
contentEditable regions.
https://bugs.webkit.org/show_bug.cgi?id=24943

Attachment 50765: Patch
https://bugs.webkit.org/attachment.cgi?id=50765&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine to change behavior.

But I don't think the specifics of the code change here is right. All we need
to do is unify the style keys with other key equivalents such as ones in the
menus. I have a patch that shows how to do this that I will attach now.

The Command-U change should not be bundled in with the part of this change that
is mentioned in the bug title. That change needs to be judged on its own
merits, and could change the behavior of existing Mac OS X applications.

WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm:430
 +	[preferences setRespectStandardStyleKeyEquivalents:YES];
Why is this change needed? Isn't this preference on by default?