[webkit-reviews] review granted: [Bug 38859] [Qt]Unskip security/set-form-autocomplete-attribute.html : [Attachment 55580] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 13 11:35:49 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 38859: [Qt]Unskip security/set-form-autocomplete-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=38859
Attachment 55580: Patch
https://bugs.webkit.org/attachment.cgi?id=55580&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:425
+ bool
DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId(QWebFrame
*frame, const QString &elementId)
Coding style issue :-) watch the placement of the * & etc
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:81
+ static bool elementDoesAutoCompleteForElementWithId(QWebFrame *frame,
const QString &elementId);
Here as well
Please fix before landing.
More information about the webkit-reviews
mailing list