[webkit-reviews] review denied: [Bug 38867] [Qt] Unskip fast/loader/main-document-url-for-non-http-loads.htm : [Attachment 55606] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 38867: [Qt] Unskip fast/loader/main-document-url-for-non-http-loads.htm
https://bugs.webkit.org/show_bug.cgi?id=38867

Attachment 55606: Patch
https://bugs.webkit.org/attachment.cgi?id=55606&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:100
 +  void QWEBKIT_EXPORT qt_dump_resource_load_callbacks_path(const QString&
path)
That is not how we name private methods, plus shouldn't this be in the
DRTSupport class you created?

WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:102
 +	dumpResourceLoadCallbacksPath = path + "/";
Is this right on all platforms? Maybe add a comment