[webkit-reviews] review granted: [Bug 39074] Web Inspector: Event Markers should be hidden in Resource's "Size" Graph : [Attachment 55992] [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 13 10:10:47 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 39074: Web Inspector: Event Markers should be hidden in Resource's "Size"
Graph
https://bugs.webkit.org/show_bug.cgi?id=39074
Attachment 55992: [PATCH] Add Show/Hide functionality to Event Dividers in
Timeline Graph
https://bugs.webkit.org/attachment.cgi?id=55992&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with nits.
WebCore/inspector/front-end/TimelineGrid.js:153
+ this._eventDividersElement.style.display = "none";
Timothy likes add/removeStyleClass("hidden"). You don't need dedicated methods
for it too...
More information about the webkit-reviews
mailing list