[webkit-reviews] review granted: [Bug 37759] [Qt] need an implementation of LayoutTestController::computedStyleIncludingVisitedInfo : [Attachment 55986] patch v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 13 09:38:24 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 37759: [Qt] need an implementation of
LayoutTestController::computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759

Attachment 55986: patch v6
https://bugs.webkit.org/attachment.cgi?id=55986&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/ChangeLog:8
 +  
why two new lines

WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:384
 +	QVariantMap ret;
ret? res would make more sense. computedStyle even more so.


More information about the webkit-reviews mailing list