[webkit-reviews] review denied: [Bug 39010] [Qt] QtField::name() returns a dangling pointer : [Attachment 55879] Patch that fixes the problem

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied  review:
Bug 39010: [Qt] QtField::name() returns a dangling pointer
https://bugs.webkit.org/show_bug.cgi?id=39010

Attachment 55879: Patch that fixes the problem
https://bugs.webkit.org/attachment.cgi?id=55879&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 59246)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2010-05-12  Anders Bakken  <agbakken at gmail.com>
> +
> +	   QObject::objectName() returns a QString and QtField::name()
> +	creates a temporary QByteArray object and returns constData() from it.
> +	This is not safe.
> +
> +	This patch changes the signature of the function to return a
> +	QByteArray instead of const char *.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=39010
> +
> +	   * bridge/qt/qt_instance.cpp:
> +	   (JSC::Bindings::QtInstance::getPropertyNames):
> +	   (JSC::Bindings::QtField::name):
> +	   * bridge/qt/qt_runtime.h:
> +

Please fix the indentation
WebCore/bridge/qt/qt_instance.cpp:234
 +	    for (i=0; i < methodCount; i++) {
i = 0, please fix the spacing

Apart from this is look fine.