[webkit-reviews] review requested: [Bug 38256] [GTK] Random failure on 'testdownload' unit test : [Attachment 55972] Make sure the set_filename function is called after handling the 'download-requested' signal for the asynchronous test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 38256: [GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Attachment 55972: Make sure the set_filename function is called after handling
the 'download-requested' signal for the asynchronous test
https://bugs.webkit.org/attachment.cgi?id=55972&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #15)
> (In reply to comment #13)
> > (From update of attachment 55275 [details] [details])
> > Seems the ChangeLog is hosed in the patch.
> 
> What do you mean?
> 
> > Also, can you explain there why are you doing what you do?

After talking to Xan via IRC I now understand his question was about the
problems with the ChangeLog and not the patch itself, so now I'm attaching a
new version of the second patch, hopefully a valid one, and non dependant on
the first patch, as the other one.