[webkit-reviews] review granted: [Bug 39051] Various JavaScript string optimizations : [Attachment 55956] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 13 01:51:51 PDT 2010


Mark Rowe (bdash) <mrowe at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 39051: Various JavaScript string optimizations
https://bugs.webkit.org/show_bug.cgi?id=39051

Attachment 55956: Patch
https://bugs.webkit.org/attachment.cgi?id=55956&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
JavaScriptCore/ChangeLog:15
 +	    (JSC::RegExp::match): resize overctor to 0 instead of clearing to
avoid
“overctor” should be “ovector”.

JavaScriptCore/runtime/StringPrototype.cpp:762
 +	    if (!(end >= 0)) // check for nevative values or NaN
“nevative” should be “negative”.

r=me


More information about the webkit-reviews mailing list