[webkit-reviews] review granted: [Bug 39043] Don't include RetainPtr.h unless PLATFORM(CF) is set : [Attachment 55941] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Young Han Lee
<joybro at company100.net>'s request for review:
Bug 39043: Don't include RetainPtr.h unless PLATFORM(CF) is set
https://bugs.webkit.org/show_bug.cgi?id=39043

Attachment 55941: patch
https://bugs.webkit.org/attachment.cgi?id=55941&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #include <errno.h>
>  #include <stdio.h>
> +#if PLATFORM(CF)
>  #include <wtf/RetainPtr.h>
> +#endif
>  #include <wtf/Threading.h>
>  #include <wtf/Vector.h>
>  #include <wtf/text/CString.h>

Includes inside #if go in their own paragraph, not sorted in the middle of the
main include paragraph.

We also normally put #if in headers so we don't have to make includes
everywhere conditional. For example, see the #if ENABLE(SVG) in SVGElement.h.
Despite those minor problems it seems OK to land this as-is.