[webkit-reviews] review granted: [Bug 38920] V8 overload support ported to JSC : [Attachment 55882] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 12 14:31:37 PDT 2010
Adam Barth <abarth at webkit.org> has granted Yaar Schnitman <yaar at chromium.org>'s
request for review:
Bug 38920: V8 overload support ported to JSC
https://bugs.webkit.org/show_bug.cgi?id=38920
Attachment 55882: Patch
https://bugs.webkit.org/attachment.cgi?id=55882&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/scripts/CodeGenerator.pm:378
+ $function->{overloadIndex} = @{$nameToFunctionsMap{$name}};
This perl is slightly mysterious to me.
This looks reasonable. It's a bit of a hack to skip the functions when the
overload index is greater than one, but I think that's ok for now.
More information about the webkit-reviews
mailing list