[webkit-reviews] review denied: [Bug 37945] CMake buildsystem : [Attachment 55750] CMake build system, with EFL port dependent files

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 37945: CMake buildsystem
https://bugs.webkit.org/show_bug.cgi?id=37945

Attachment 55750: CMake build system, with EFL port dependent files
https://bugs.webkit.org/attachment.cgi?id=55750&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +IF (NOT WTF_USE_ICU_UNICODE)
> +    ADD_DEFINITIONS(-DWTF_USE_ICU_UNICODE=0)

/home/manyoso/dev/webkit_1/JavaScriptCore/wtf/Platform.h:580:1: warning:
"WTF_USE_ICU_UNICODE" redefined

This is in cross-platform wtf/CMakeLists.txt and in Platform.h you can see that
you are re-defining it.

This needs to be fixed.