[webkit-reviews] review granted: [Bug 38143] move chrome extension code for fancy-review into bugzilla : [Attachment 55876] Updates to address all comments from review.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 12 13:41:36 PDT 2010
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Julie Parent
<jparent at google.com>'s request for review:
Bug 38143: move chrome extension code for fancy-review into bugzilla
https://bugs.webkit.org/show_bug.cgi?id=38143
Attachment 55876: Updates to address all comments from review.
https://bugs.webkit.org/attachment.cgi?id=55876&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: BugsSite/ChangeLog
> + * template/en/custom/attachment/rietveldreview.html.tmpl: Added.
> + New template for fancyreview mode. Hosts the rietveld frame in
the
> + top and the regular comments form in the bottom.
> + Uses postMessage to communicate with Rietveld frame.
Nit: "fancyreview" should be "reitveldreview" here.
r=me
More information about the webkit-reviews
mailing list