[webkit-reviews] review granted: [Bug 38939] [Qt] Implement a detachPage method for QGraphicsWebView and QWebView : [Attachment 55764] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 07:27:35 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 38939: [Qt] Implement a detachPage method for QGraphicsWebView and QWebView
https://bugs.webkit.org/show_bug.cgi?id=38939

Attachment 55764: patch v1
https://bugs.webkit.org/attachment.cgi?id=55764&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Maybe use detachCurrentPage? I would also like an autotest actually testing the
fix you did for always clearing the view when setting a new page, but it can be
a separate patch.


More information about the webkit-reviews mailing list