[webkit-reviews] review denied: [Bug 38989] [Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachPage : [Attachment 55840] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 12 07:17:08 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 38989: [Qt] Remove the unneeded check for QWidgetPageClient
@QGraphicsWebView::detachPage
https://bugs.webkit.org/show_bug.cgi?id=38989
Attachment 55840: patch v1
https://bugs.webkit.org/attachment.cgi?id=55840&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/Api/qgraphicswebview.cpp:451
+ delete page->d->client;
No need to use an if, delete'ing a null pointer does nothing.
More information about the webkit-reviews
mailing list