[webkit-reviews] review requested: [Bug 38987] [Qt] The QScriptValue autotest should be refactored. : [Attachment 55839] Fix v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 06:40:34 PDT 2010


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked  for review:
Bug 38987: [Qt] The QScriptValue autotest should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=38987

Attachment 55839: Fix v1
https://bugs.webkit.org/attachment.cgi?id=55839&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
Patch overview:
1. tst_qscriptvalue_generated.cpp was removed.
2. 3 new files were created with content of the removed file.
 - tst_qscriptvalue_generated_init.cpp - contains test data set (tested
values).
 - tst_qscriptvalue_generated_isXXX.cpp - contains expected results and tests
for QScriptValue::isXXX methods.
 - tst_qscriptvalue_generated_toXXX.cpp -  contains expected results and tests
for QScriptValue::toXXX methods.
3. typical test was changed; expected values are loaded via loops and static
arrays (instead of nearby infinite numbers of insert() and operator<<() calls
:-) ).
4. expected values weren't changed.
5. the same content (methods, values) is tested.
6. all tests pass.


More information about the webkit-reviews mailing list