[webkit-reviews] review granted: [Bug 38667] Web Inspector: add help on keyboard shortcuts : [Attachment 55834] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 38667: Web Inspector: add help on keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=38667

Attachment 55834: patch
https://bugs.webkit.org/attachment.cgi?id=55834&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with comments, please fix prior to landing.

WebCore/inspector/front-end/ConsoleView.js:104
 +	var shortcut = WebInspector.KeyboardShortcut;
extract method?

WebCore/inspector/front-end/ElementsPanel.js:110
 +	var shortcut = WebInspector.KeyboardShortcut;
extract method + fill style shortcuts from here as well or call explicit method
on styles sidebar.

WebCore/inspector/front-end/ScriptsPanel.js:178
 +	section.addAlternateKeys([ shortcut1.name, shortcut2.name ],
"Continue");
consider extracting.

WebCore/inspector/front-end/ShortcutsHelp.js:101
 +	get height()
_ is private to a compilation unit, not a class.

WebCore/inspector/front-end/ShortcutsHelp.js:51
 +	this._helpScreen.show();
tab?