[webkit-reviews] review denied: [Bug 38896] [GTK] Theme does not render when printing : [Attachment 55825] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 05:13:56 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 38896: [GTK] Theme does not render when printing
https://bugs.webkit.org/show_bug.cgi?id=38896

Attachment 55825: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55825&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
We can use GRefPtr for the pixmap, so r- to do that.

It also seems when there's no expose event and printing is disabled we'll
create a pixmap just to immediately destroy it, which seems a bit pointless.


More information about the webkit-reviews mailing list