[webkit-reviews] review denied: [Bug 38256] [GTK] Random failure on 'testdownload' unit test : [Attachment 55274] 1. Init timer to 0 on instance init

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 05:02:37 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 38256: [GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Attachment 55274: 1. Init timer to 0 on instance init
https://bugs.webkit.org/attachment.cgi?id=55274&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
We cannot got this in like this. The ChangeLog message is not useful because
you don't explain why are you doing that; you could say it's just for
consistency-sake at the very least, although that would be false since we don't
really consistently init all private members to zero.

Since this does not really fix anything I think we should not get it in unless
we stablish some policy about doing this everywhere.


More information about the webkit-reviews mailing list