[webkit-reviews] review canceled: [Bug 38925] Web Inspector: Timeline. Send Request records initiated by JS have no parent. : [Attachment 55745] [patch] initial version.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 12 02:41:59 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has canceled Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 38925: Web Inspector: Timeline. Send Request records initiated by JS have
no parent.
https://bugs.webkit.org/show_bug.cgi?id=38925
Attachment 55745: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=55745&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/TimelineAgent.js:57
+ DelayedRequest : 20
SchedulePendingRequests ?
WebCore/loader/loader.cpp:153
+ agent->didDelayedRequest(request);
I'd use more strict binding to sendrequest. Using the "url + cached resource
address" will already be less ambiguous.
More information about the webkit-reviews
mailing list