[webkit-reviews] review denied: [Bug 38978] [chromium] add DRT back to the chromium build : [Attachment 55812] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 12 00:20:12 PDT 2010
Kent Tamura <tkent at chromium.org> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 38978: [chromium] add DRT back to the chromium build
https://bugs.webkit.org/show_bug.cgi?id=38978
Attachment 55812: Patch
https://bugs.webkit.org/attachment.cgi?id=55812&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
> diff --git a/WebKit/chromium/WebKit.gyp b/WebKit/chromium/WebKit.gyp
> index
fe2d5890f787b4db96d6b8959820b4b0ec30e2c2..be69a572129ff052158fd191304bb497b7f37
15f 100644
> --- a/WebKit/chromium/WebKit.gyp
> +++ b/WebKit/chromium/WebKit.gyp
> @@ -535,6 +535,85 @@
> ],
> },
> {
> + 'target_name': 'DumpRenderTree',
> + 'type': 'executable',
> + 'mac_bundle': 1,
> + 'dependencies': [
> + 'webkit',
> +
'../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:wtf_config',
> + '<(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
> + '<(webkit_support_gyp):webkit_support',
> + ],
> + 'include_dirs': [
> + '.',
> + '../../JavaScriptCore',
> + '<(DEPTH)',
> + ],
'include_dirs' without this patch contains 4 lines. It seems a line was removed
accidentally.
More information about the webkit-reviews
mailing list