[webkit-reviews] review granted: [Bug 37502] Web Inspector: Removes public callLocation API from ScriptCallStack and replaces with ability to get top 10 stack frames : [Attachment 55774] uses new v8 stacktrace api.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 22:07:00 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted jaimeyap at google.com's request
for review:
Bug 37502: Web Inspector: Removes public callLocation API from ScriptCallStack
and replaces with ability to get top 10 stack frames
https://bugs.webkit.org/show_bug.cgi?id=37502

Attachment 55774: uses new v8 stacktrace api.
https://bugs.webkit.org/attachment.cgi?id=55774&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Great job! Make sure you roll the WebKit deps bots as suggested by David.

WebCore/bindings/v8/ScriptCallStack.cpp:97
 +	if (trace.IsEmpty() || !trace->GetFrameCount()) {
no { } needed

WebCore/bindings/v8/ScriptCallStack.cpp:98
 +	  return false;
wrong indent

WebCore/inspector/TimelineRecordFactory.cpp:53
 +	if (ScriptCallStack::stackTrace(5, frontend->scriptState(),
stackTrace)) {
no { } needed


More information about the webkit-reviews mailing list