[webkit-reviews] review denied: [Bug 38947] [chromium] Expose volume through WebMediaPlayerClient : [Attachment 55783] Adds needed accessors to WebMediaPlayerClient

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Simonsen
<simonjam+webkit at google.com>'s request for review:
Bug 38947: [chromium] Expose volume through WebMediaPlayerClient
https://bugs.webkit.org/show_bug.cgi?id=38947

Attachment 55783: Adds needed accessors to WebMediaPlayerClient
https://bugs.webkit.org/attachment.cgi?id=55783&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:396
 +  float WebMediaPlayerClientImpl::volume() const
It looks like you have not inserted this method definition after the definition
of
sawUnsupportedTracks.  Please fix that so that methods in the .cpp file are
defined in the same order in which they are declared in the .h file.  Thanks!