[webkit-reviews] review granted: [Bug 38936] sheriffbot is spammy. : [Attachment 55792] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38936: sheriffbot is spammy.
https://bugs.webkit.org/show_bug.cgi?id=38936

Attachment 55792: Patch
https://bugs.webkit.org/attachment.cgi?id=55792&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/tool/commands/sheriffbot.py:64
 +	    # been that skippign this check causes a lot of spam for builders
that
skippign

Makes sense.

I still think our sheriffbot arch is less than optimal.  I would like him
eventually to hold in memory and increasingly good picture of what went wrong. 
So that one can ask him "what's broken" and he can tell you the exact revision
and what it broke.  Right now he just warns as he gets information and doesn't
keep around any bigger picture.

Ideally we should cross-reference builds to figure out what actually started
when and hold multiple "break" objects or something in memory.	Then we would
warn about them every 30m or something until they got fixed, and could explain
all the information we know about them over IRC when asked.