[webkit-reviews] review requested: [Bug 38845] Canvas color property getters should serialize them according to spec : [Attachment 55794] Proposed patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 18:47:42 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 38845: Canvas color property getters should serialize them according to
spec
https://bugs.webkit.org/show_bug.cgi?id=38845

Attachment 55794: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=55794&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Style fixed + CanvasStyle slightly slimmed.

Dirk, I don't think I'm violating the spec here, it reads to me as if this
format should be acceptable.
If nothing else, it's what Gecko does. (Weak argument, I know.)

That said, I would personally also prefer returning "0.4" instead of "0.40000".
Is there a simple way to do this?


More information about the webkit-reviews mailing list