[webkit-reviews] review denied: [Bug 38874] Adding block elements to a block and removing them changes the height of the element : [Attachment 55710] Patch2

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 38874: Adding block elements to a block and removing them changes the
height of the element
https://bugs.webkit.org/show_bug.cgi?id=38874

Attachment 55710: Patch2
https://bugs.webkit.org/attachment.cgi?id=55710&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You really want to revert back to childrenInline = true when kids get removed,
not at layout time.  RenderBlock::removeChild seems like a better place to do
this than layoutBlock.	Something like this:

if (!firstChild() && !childrenInline() && isRenderBlock())
    setChildrenInline(true);

Strictly speaking you could even revert back to childrenInline = true if all
you have left are floating/positioned children, but that could get expensive to
check, so I wouldn't bother.