[webkit-reviews] review granted: [Bug 38685] [Qt] tst_QWebPage::inputMethods failing on Maemo5 : [Attachment 55739] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 38685: [Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685

Attachment 55739: Patch
https://bugs.webkit.org/attachment.cgi?id=55739&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1384
 +	// part of the test can verified as the checks bellow.
below

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1381
 +	// because there is no SIP (Software Input Panel) triggered. In case of
mobile
In the case of a mobile platform, AN input panel

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1382
 +	// platforms a input panel, e.g. virtual keyboard, is normally invoked
and the
usually might be better than normally

WebKit/qt/ChangeLog:10
+	  Check if the SIP (Software Input Panel) is triggered,
+	  which normally happens on mobile platforms, when a user input form
receives
+	  a mouse click.

Strange word wrap