[webkit-reviews] review denied: [Bug 38685] [Qt] tst_QWebPage::inputMethods failing on Maemo5 : [Attachment 55735] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 11 12:29:56 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 38685: [Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685
Attachment 55735: Patch
https://bugs.webkit.org/attachment.cgi?id=55735&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1371
+ int inputPanel= 0;
wrong coding style
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1383
+ QVERIFY(!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel));
As said earlier, can be please add a comment here explaining the difference
More information about the webkit-reviews
mailing list