[webkit-reviews] review granted: [Bug 38913] REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works : [Attachment 55720] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 38913: REGRESSION(r58520): Implicit submission on forms with button
type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913

Attachment 55720: Patch
https://bugs.webkit.org/attachment.cgi?id=55720&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I would have preferred to see the bug fix separate from the cleanup. Clearly
all that was needed to fix the bug was to check isSuccessfulSubmitButton even
when the element is not an <input>. And the renaming and refactoring obscures
that change.

The final resulting code looks great.

r=me