[webkit-reviews] review denied: [Bug 34539] NP_VERSION_MINOR is not correct for some ports : [Attachment 55694] Implements NPN_GetValueForURL and NPN_SetValueForURL, stub for NPN_GetAuthenticationInfo [Update III]

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied adawit at kde.org's request for
review:
Bug 34539: NP_VERSION_MINOR is not correct for some ports
https://bugs.webkit.org/show_bug.cgi?id=34539

Attachment 55694: Implements NPN_GetValueForURL and NPN_SetValueForURL, stub
for NPN_GetAuthenticationInfo [Update III]
https://bugs.webkit.org/attachment.cgi?id=55694&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
> +
> +// FIXME: This is added to work around build failure by the qt/gtk build
boats.
> +// See comments # 11,14 & 15 of
https://bugs.webkit.org/show_bug.cgi?id=34539.
> +#ifndef _INT32
> +#define _INT32
> +#ifdef __LP64__
> +typedef int int32;
> +typedef unsigned int uint32;
> +#else /* __LP64__ */
> +typedef long int32;
> +typedef unsigned long uint32;
> +#endif /* __LP64__ */
> +#endif
> +
> +

This is wrong. You should use the new C99 types instead, int32_t and uint32_t.

Marking r- for this reason.