[webkit-reviews] review granted: [Bug 38688] Support control attribute of HTMLLabelElement : [Attachment 55650] Patch addressing comment #13.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 38688: Support control attribute of HTMLLabelElement
https://bugs.webkit.org/show_bug.cgi?id=38688

Attachment 55650: Patch addressing comment #13.
https://bugs.webkit.org/attachment.cgi?id=55650&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -HTMLElement* HTMLLabelElement::correspondingControl()
> +HTMLElement* HTMLLabelElement::control()

Why isn't the return type of this HTMLFormControlElement*? There are a lot of
places in this patch that use HTMLElement* but instead should use
HTMLFormControlElement.

> +	   // Search the children and descendants of the label element for a
form element.
> +	   // per http://dev.w3.org/html5/spec/Overview.html#the-label-element
> +	   // the form element must be "labelable form-associated element".

I think the comment should just leave out the link and say something more like
this:

    // HTML5 says to search our descendants for the first labelable
form-associated element
    // in document order.

OK as-is, though.