[webkit-reviews] review canceled: [Bug 38874] Adding block elements to a block and removing them changes the height of the element : [Attachment 55618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 09:35:11 PDT 2010


Enrica Casucci <enrica at apple.com> has canceled Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 38874: Adding block elements to a block and removing them changes the
height of the element
https://bugs.webkit.org/show_bug.cgi?id=38874

Attachment 55618: Patch
https://bugs.webkit.org/attachment.cgi?id=55618&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
Changed the border color to green and used appendChild instead of innerText to
allow you to see the test in Firefox.
Firefox behaves differently because it returns 0 height for empty editable
blocks, but it is consistent. This bugs is about inconsistency of before and
after.
I've discussed this with Hyatt on IRC and he agreed on the approach.


More information about the webkit-reviews mailing list