[webkit-reviews] review granted: [Bug 38630] VS2010 asserts a null iterator passed to std::copy in Vector::operator= : [Attachment 55682] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 08:44:49 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 38630: VS2010 asserts a null iterator passed to std::copy in
Vector::operator=
https://bugs.webkit.org/show_bug.cgi?id=38630

Attachment 55682: Patch v2
https://bugs.webkit.org/attachment.cgi?id=55682&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+// Workarounds an assert in VS2010. See
https://bugs.webkit.org/show_bug.cgi?id=38630

There is no verb "workarounds", it's either a noun or "works around". I still
think that it would be better to have a direct link to MS issue. The use case
for this comment is: can I remove this code now? - click link - read. With a
Bugzilla link, there is an extra step involved. On the other hand, the Bugzilla
link may be more stable.

r=me, but please fix the grammar issue.


More information about the webkit-reviews mailing list