[webkit-reviews] review denied: [Bug 38667] Web Inspector: add help on keyboard shortcuts : [Attachment 55699] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 38667: Web Inspector: add help on keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=38667

Attachment 55699: patch
https://bugs.webkit.org/attachment.cgi?id=55699&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Almost there...

WebCore/inspector/front-end/HelpScreen.js:1
 +  WebInspector.HelpScreen = function(sections, nColumns)
You need copyright here.

WebCore/inspector/front-end/HelpScreen.js:97
 +  WebInspector.shortcutsHelpSection = function(name)
It'd be great to have this on some singleton class corresponding to keyboard
shortcuts screen. That class would also have methods for showing / hiding it.

WebCore/inspector/front-end/HelpScreen.js:105
 +  WebInspector.ShortcutsSection = function(name)
You want this in a separate file (ShortcutsScreen.js probably).