[webkit-reviews] review granted: [Bug 38799] Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs : [Attachment 55681] Updated patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 38799: Move buildLayoutInformationForTextBox() from SVGRootInlineBox in
SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799

Attachment 55681: Updated patch
https://bugs.webkit.org/attachment.cgi?id=55681&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
WebCore/rendering/SVGInlineTextBox.cpp:718
 +		if (info.pathTextLength > 0.0f && info.pathChunkLength > 0.0f)
{ 
Maybe the style bot was right here (info.pathTextLength &&
info.pathChunkLength) :-)

WebCore/rendering/SVGInlineTextBox.cpp:252
 +	    if (closestOffsetInBox < (int) end() && direction() == RTL)
not static_cast<int> here?

WebCore/rendering/SVGTextLayoutUtilities.cpp:164
 +		//	 Text which is not fullwidth will be set with a
glyph-orientation of 90-degrees.
IIRC we don't want leading spaces here.

WebCore/rendering/SVGTextLayoutUtilities.cpp:322
 +	    if (primitive->primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE
&& font.pixelSize() > 0)
font.pixelSize() > 0 the same like above

Patch looks goo. r=me, but please think about the style hints.