[webkit-reviews] review requested: [Bug 38630] VS2010 asserts a null iterator passed to std::copy in Vector::operator= : [Attachment 55682] Patch v2

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 38630: VS2010 asserts a null iterator passed to std::copy in
Vector::operator=
https://bugs.webkit.org/show_bug.cgi?id=38630

Attachment 55682: Patch v2
https://bugs.webkit.org/attachment.cgi?id=55682&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
(In reply to comment #11)
> This doesn't look like it could possibly work. Did you run regression tests
with this patch? Or am I just confused?

No, there was a lack of testing from my part on this patch, sorry about that.

Here is the first patch enclosed to apply only when the assert would pop.
Adding only "else if (!other.size()) return *this;" would not prevent the
assert when size() > other.size() and the buffer gets shrunk to 0.

See Comment #7 for a link to the reported visual studio bug.