[webkit-reviews] review denied: [Bug 38845] Canvas color property getters should serialize them according to spec : [Attachment 55557] Proposed patch, first stab + stylefixes

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38845: Canvas color property getters should serialize them according to
spec
https://bugs.webkit.org/show_bug.cgi?id=38845

Attachment 55557: Proposed patch, first stab + stylefixes
https://bugs.webkit.org/attachment.cgi?id=55557&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
I'm also a bit unhappy about the parsing code. We have some bugs about the
performance issues on color parsing. So it's not a good idea to parse the color
multiple times: in setFill(/Stroke/Shadow)Color and again in
CanvasStyle::applyFill(/Stroke/Shadow)Color().